Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update panther_analysis_tool version #1108

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Update panther_analysis_tool version #1108

merged 2 commits into from
Feb 13, 2024

Conversation

nskobov
Copy link
Contributor

@nskobov nskobov commented Feb 13, 2024

Background

PAT just had a release. updating the version in the panther-analysis pipfile

Changes

  • pipfile version bump

Testing

@nskobov nskobov requested review from a team February 13, 2024 21:37
Copy link

github-actions bot commented Feb 13, 2024

😱
looks like somethings could be wrong with the packs

[ERROR][root]: There are packs that are potentially missing detections: crowdstrike.yml: OnePassword.Login.From.CrowdStrike.Unmanaged.Device,AWS.Authentication.From.CrowdStrike.Unmanaged.Device,Okta.Login.From.CrowdStrike.Unmanaged.Device dropbox.yml: Dropbox.Many.Downloads,Dropbox.Many.Deletes gcp_audit.yml: GCP.compute.instances.create.Privilege.Escalation
<!-- thollander/actions-comment-pull-request "check-packs" -->

@egibs
Copy link
Contributor

egibs commented Feb 13, 2024

@nskobov -- can you run make deps-update as well?

@nskobov
Copy link
Contributor Author

nskobov commented Feb 13, 2024

@nskobov -- can you run make deps-update as well?

just ran it locally and pushed it up. a bit scary this doesnt happen in CI, as what if my local env causes the pipenv update to behave differently

@egibs
Copy link
Contributor

egibs commented Feb 13, 2024

@nskobov -- can you run make deps-update as well?

just ran it locally and pushed it up. a bit scary this doesnt happen in CI, as what if my local env causes the pipenv update to behave differently

It uses the contents of your local Pipfile so you could theoretically push up a lockfile change with undesired changes but we'd still catch it in a PR.

@egibs egibs merged commit 50fd32b into main Feb 13, 2024
6 checks passed
@egibs egibs deleted the nskobov-patch-1 branch February 13, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants